showOnClick doesn't hide submenu when clicked again

[dameer]

hi,
was wondering how come

showOnClick: true

option doesn’t allow closing the submenu when the same menu item is clicked second time? clicking elsewhere, however, does. am I missing some other setting?

[admin]

Hi, actually you are not missing anything. It’s currently really working like that by default. I will most probably change this in the next release. In the meantime, you could use the following tweak via the API to achieve what you need:

// SmartMenus jQuery - a second click on a main menu item when "showOnClick: true" should hide the sub menu
$('#main-menu').on('click.smapi', function(e, item) {
	if (e.namespace == 'smapi') {
		var obj = $(this).data('smartmenus');
		if (!obj.isCollapsible() && obj.opts.showOnClick) {
			var $sub = $(item).dataSM('sub'),
				firstLevelSub = $sub ? $sub.dataSM('level') == 2 : false;
			if (firstLevelSub && $sub.is(':visible')) {
				obj.menuHide($sub);
				obj.clickActivated = false;
				return false;
			}
		}
	}
});

Cheers!

Edit: Just add this code after your SmartMenus init code.

[dameer]

Oho! Now the things work much better 😀 The only problem is the fact that the above code is OK for the level-1 sub-menu. In case there’s a sub-menu item which opens level-2 sub-menu, the second click will shut down all sub-menus been opened.

Thanks for a great work and all of your efforts!

[dameer]

OK, got it resolved by replacing the line:

firstLevelSub = $sub ? $sub.dataSM('level') == 2 : false;

…with just:

firstLevelSub = $sub ? $sub.dataSM('level') >= 2 : false;

Cheers!

[Author]

Posts